Gina add % fails when pwd is not git root

[lambdalisue]

1. cd gina.vim && vim
2. :cd autoload
3. :e test
4. :w
5. :Gina add %
6. :Gina status

[lambdalisue]

The :Gina add % executes a command as

git -C {repository} ... add test

And the -C seems the reason while

       -C <path>
           Run as if git was started in <path> instead of the current working directory. When multiple -C options are given, each subsequent
           non-absolute -C <path> is interpreted relative to the preceding -C <path>.

           This option affects options that expect path name like --git-dir and --work-tree in that their interpretations of the path names would
           be made relative to the working directory caused by the -C option. For example the following invocations are equivalent:

               git --git-dir=a.git --work-tree=b -C c status
               git --git-dir=c/a.git --work-tree=c/b status

So a given test is searched from a root directory of the git repository rather than the autoload directory so fail.

Workaround

Use %:p instead

:Gina add %:p

[ujihisa]

thanks! @lambdalisue++

[doronbehar]

Maybe the solution to this would consist of having a dedicated gina command handler for :Gina add in autoload/gina/command/add.vim?

[lambdalisue]

It's actually quite complicated. Assume gina.vim repository is in /Users/alisue/gina.vim and autoload/gina.vim is modified then

1. Gina state shows M autoload/gina.vim when cwd is /Users/alisue/gina.vim/autoload/
2. Gina state also shows M autoload/gina.vim when cwd is /Users/alisue/gina.vim/ rather than M . gina.vim when git -C is used
3. << or >> in gina-status buffer internally use Gina add command

Thus I cannot simply use fnamemodify({path}, ':p') or whatever to make an absolute path or a relative path from the repository root.