This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Replaced deploy_contract() in favor of set_class_hash_at() plus an availability check #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 91.74% 91.60% -0.14%
==========================================
Files 54 54
Lines 12842 12880 +38
==========================================
+ Hits 11782 11799 +17
- Misses 1060 1081 +21
|
Oppen
reviewed
Jul 21, 2023
Comment on lines
+763
to
+773
| let state = &mut self.starknet_storage_state.state; | ||
| match state.get_class_hash_at(&contract_address) { | ||
| Ok(x) if x == [0; 32] => {} | ||
| Ok(_) => { | ||
| return Err( | ||
| StateError::ContractAddressUnavailable(contract_address.clone()).into(), | ||
| ) | ||
| } | ||
| _ => {} | ||
| } | ||
| state.set_class_hash_at(contract_address.clone(), class_hash_bytes) |
There was a problem hiding this comment.
This looks a lot like something that could be its own function.
There was a problem hiding this comment.
Yeah, it was deploy_contract(). We could talk with @juanbono about the decision of removing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced deploy_contract() in favor of set_class_hash_at() plus an availability check
Description
Closes #826
Checklist