Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] process_step_for_unit/4 #498

Open
ncontinanza opened this issue Jun 12, 2024 · 0 comments
Open

[REFACTOR] process_step_for_unit/4 #498

ncontinanza opened this issue Jun 12, 2024 · 0 comments
Labels
refactor Changes that refactor code, including changes to implement better code practices
Milestone
Beta - Testing + ...

Comments

@ncontinanza
Copy link
Collaborator

🚧 Refactor

In Simulator.ex, the function process_step_for_unit/4 has grown a lot and is quite hard to follow right now. We should refactor it and break it into smaller functions, maybe following the same convention as simulate_battle/3
@ncontinanza ncontinanza added the refactor Changes that refactor code, including changes to implement better code practices label Jun 12, 2024
@ncontinanza ncontinanza mentioned this issue Jun 12, 2024
Merged
4 tasks
@lotuuu lotuuu added this to the Beta - Testing + Bug Fixing milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Changes that refactor code, including changes to implement better code practices
Projects
None yet
Milestone
Beta - Testing + Bug Fixing
Development

No branches or pull requests
2 participants
@ncontinanza @lotuuu