Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Unify the representation of the type field in targeting strategies #479

Open
ncontinanza opened this issue Jun 3, 2024 · 0 comments
Labels

Comments

@ncontinanza
Copy link
Collaborator

🚧 Refactor

Check the first and last comment left in: lambdaclass/mirra_backend#647

In our current targeting strategies, the type field is a string in some cases and a map in others. It would be better to have type as a string and a separate stat field for the cases in which corresponds (highest and lowest targeting strategies, for instance).

This refactor will help to simplify the implementation of create_mechanics_map/3, where we're currently implementing different behaviors for the string and the map case.

Also, talk with Game Design in order to make this change in the design documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant