[GH-467] Unequip previously equipped item on equip #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustinesco
reviewed
Jun 12, 2024
Co-authored-by: Agustin Escobar <[email protected]>
agustinesco
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Items of the same type were not being unequipped when a unit equipped another one. We marked this as a bug instead of a feature because we thought it was already inclemented, but it seems like we just never actually did it.
Closes lambdaclass/afk_gacha_game#467
Summary of changes
How to test it?
Create two items, or use the ones you gain by winning the first few levels of the campaign. Equip one of them to a unit. Then equip the other one (of the same type). Query the initial one, and you should see that its'
unit_idisnil