Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: dataset 2420, read and write keys are not the same #50

Open
jasasonc opened this issue Jul 7, 2021 · 3 comments
Open

BUG: dataset 2420, read and write keys are not the same #50

jasasonc opened this issue Jul 7, 2021 · 3 comments

Comments

@jasasonc
Copy link
Contributor

jasasonc commented Jul 7, 2021

The keys in output dictionary when reading dataset 2420 are different from expected keys when writing this set.

def _extract2420(blockData):

def _write2420(fh, dset):

Similar issue is present in dataset 2411. Partially connected to #43

@jankoslavic
Copy link
Contributor

@jasasonc is this still an issue?

@jasasonc
Copy link
Contributor Author

jasasonc commented Dec 29, 2021

Yes.
write2420 requires keys: part_UID, part_name, cs_type, cs_color, nodes.

extract2420 creates keys: Part_UID, Part_Name, CS_sys_labels, CS_types, CS_colors, CS_names, CS_matrices

@jankoslavic
Copy link
Contributor

Dear @jasasonc thank you!

I see!
The extract2420 follows the datatype specifications available here: https://www.ceas3.uc.edu/sdrluff/view.php
We have a partial test here:
https://github.com/ladisk/pyuff/blob/master/tests/test_2420.py

We need help in handling this issue and also a real dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants