How to make path params work in unit tests without having to add in request struct?

[bhambrah-asbuilt]

am using echo v4.12.0 and am facing this issue in unit tests.
doing c.SetParamNames(), c.SetParamValues() in test doesn't make c.Bind() work for path params

as a workaround, i need to add the param in the request struct in the unit test or add c.Param() in the actual function.

reference to setting path params in test: https://echo.labstack.com/docs/testing#setting-path-params

[bhambrah-asbuilt]

request struct:

type TestRequest struct {
	TestParamOne string `param:"test_param_one"`
	TestParamTwo string `param:"test_param_two"`
	TestJsonOne string `json:"test_json_param"`
}

if I add unit test like this, it fails because c.Bind() doesn't work as expected for the path params; json params work as expected.

func Test() {
      req := TestRequest {
            TestJsonOne: "9",
      }
      
      var buf bytes.Buffer
      err := json.NewEncoder(&buf).Encode(updateReq)
      if err != nil {
            panic(err)
      }
      
      req := httptest.NewRequest(http.MethodPost, "/test/:test_param_one/:test_param_two", &buf)
      rec := httptest.NewRecorder()
      
      e := echo.New()
      c := e.NewContext(req, rec)
      c.SetParamNames("test_param_one", "test_param_two")
      c.SetParamValues("9", "9")
}

[bhambrah-asbuilt]

having to update request struct in test as a workaround.
works correctly without c.SetParamNames(), c.SetParamValues() , which implies it's not working as expected with c.Bind()

req := TestRequest {
      TestParamOne: "9",
      TestParamTwo: "9"
      TestJsonOne: "9",
}

[aldas]

The problem is that

	type Req struct {
		TestParamOne string `param:"test_param_one"`
		TestParamTwo string `param:"test_param_two"`
		TestJsonOne  string `json:"test_json_param"`
	}

	payload := Req{
		TestJsonOne: "json1",
	}
	var buf bytes.Buffer
	if err := json.NewEncoder(&buf).Encode(payload); err != nil {
		t.Fatal(err)
	}
	fmt.Printf(buf.String())

will result to body being
{"TestParamOne":"","TestParamTwo":"","test_json_param":"json1"}

and when it comes to binding - json fields will overwrite path fields.

This test would work as it passes json body without these fields as empty to request

package main

import (
	"bytes"
	"github.com/labstack/echo/v4"
	"net/http"
	"net/http/httptest"
	"testing"
)

func TestName(t *testing.T) {
	type Req struct {
		TestParamOne string `param:"test_param_one"`
		TestParamTwo string `param:"test_param_two"`
		TestJsonOne  string `json:"test_json_param"`
	}

	req := httptest.NewRequest(http.MethodPost, "/test/:test_param_one/:test_param_two", bytes.NewBuffer([]byte(`{"test_json_param":"json1"}`)))
	req.Header.Set(echo.HeaderContentType, echo.MIMEApplicationJSON)
	rec := httptest.NewRecorder()

	e := echo.New()
	c := e.NewContext(req, rec)
	c.SetParamNames("test_param_one", "test_param_two")
	c.SetParamValues("param1", "param2")

	handler := func(c echo.Context) error {
		payload := Req{}
		if err := c.Bind(&payload); err != nil {
			return err
		}
		return c.JSON(http.StatusOK, payload)
	}

	err := handler(c)
	if err != nil {
		t.Fatal(err)
	}

	body := rec.Body.String()
	if "{\"TestParamOne\":\"param1\",\"TestParamTwo\":\"param2\",\"test_json_param\":\"json1\"}\n" != body {
		t.Errorf("unexpected response, got: %s", body)
	}
}