Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DigitalInputProtocol, GpioDigitalInputDriver #1457

Open
flxzt opened this issue Jul 31, 2024 · 2 comments · May be fixed by #1458
Open

Add DigitalInputProtocol, GpioDigitalInputDriver #1457

flxzt opened this issue Jul 31, 2024 · 2 comments · May be fixed by #1458

Comments

@flxzt
Copy link
Contributor

flxzt commented Jul 31, 2024 •
edited
Loading

Currently it is only possible to specify GPIO's as outputs see here.

I am proposing to add a DigitalInputProtocol together with a GpioDigitalInputDriver that configures GPIO pins as input only through sysfs (or switch to the newer devfs/libgpiod based GPIO interface while at it, because the sysfs one is deprecated).
This could ensure that there won't be any shorts when the pin is connected to an output of the DUT.
@jluebbe
Copy link
Member

jluebbe commented Jul 31, 2024 •
edited
Loading

Please see #468 for the libgpiod discussion.

Adding a corresponding DigitalInputProtocol and GpioDigitalInputDriver to the existing sysfs variant would be useful though. Sharing most of the agent code seems relatively easy. Do you intend to create a PR?

@flxzt
Copy link
Contributor Author

flxzt commented Jul 31, 2024

I see. Having to keep a process open is a limitation of the devfs based interface that I didn't have in mind. Yes, I intend to add it. I'll see if I can come up with a sysfs based implementation similar to the existing agent code then

@flxzt flxzt linked a pull request Jul 31, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

protocol/driver: add DigitalInputProtocol, GpioDigitalInputDriver flxzt/labgrid
2 participants
@jluebbe @flxzt