Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluxCD helmrelease parameter: pullInterval should be set in the spec.chart.spec.interval, not spec.interval #767

Closed
MiD10 opened this issue Dec 3, 2024 · 1 comment

Comments

@MiD10
Copy link
Contributor

MiD10 commented Dec 3, 2024

https://github.com/kubevela/catalog/blob/ade56fcb667b1eaa27419cf4082d0ebc78bd2dc1/addons/fluxcd/definitions/helm-release-def.cue#L128C1-L163C5

	output: {
		apiVersion: "helm.toolkit.fluxcd.io/v2beta1"
		kind:       "HelmRelease"
		metadata: {
			name: context.name
		}
		spec: {
			timeout:  parameter.installTimeout
			interval: parameter.pullInterval ----> should be parameter.interval
			chart: {
				spec: {
					chart:   parameter.chart
					version: parameter.version
					sourceRef: {
						if parameter.repoType == "git" {
							kind: "GitRepository"
						}
						if parameter.repoType == "helm" || parameter.repoType == "oci" {
							kind: "HelmRepository"
						}
						if parameter.repoType == "oss" {
							kind: "Bucket"
						}
						if parameter.sourceName == _|_ {
							name: context.name
						}
						if parameter.sourceName != _|_ {
							name: parameter.sourceName
						}
					}
					interval: parameter.interval ----> should be parameter.pullInterval
					if parameter["valuesFiles"] != _|_ {
						valuesFiles: parameter["valuesFiles"]
					}
				}
			}
@MiD10
Copy link
Contributor Author

MiD10 commented Dec 3, 2024

according to the parameter usage:
https://github.com/kubevela/catalog/blob/ade56fcb667b1eaa27419cf4082d0ebc78bd2dc1/addons/fluxcd/definitions/helm-release-def.cue#L223C1-L238C22

	parameter: {
		repoType: *"helm" | "git" | "oss" | "oci"
		// +usage=The interval at which to check for repository/bucket and release updates, default to 5m
		pullInterval: *"5m" | string
		// +usage=The  Interval at which to reconcile the Helm release, default to 30s
		interval: *"30s" | string

@MiD10 MiD10 changed the title Fluxcd helmrelease parameter: pullInterval should be set in the spec.chart.spec.interval, not spec.interval FluxCD helmrelease parameter: pullInterval should be set in the spec.chart.spec.interval, not spec.interval Dec 3, 2024
MiD10 pushed a commit to MiD10/catalog that referenced this issue Dec 3, 2024
MiD10 added a commit to MiD10/catalog that referenced this issue Dec 3, 2024
MiD10 added a commit to MiD10/catalog that referenced this issue Dec 3, 2024
MiD10 added a commit to MiD10/catalog that referenced this issue Dec 3, 2024
@MiD10 MiD10 closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant