fix: grafana pvc config not working #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
grafana在配置使用pvc时，例如设置为1G的存储时，并不会生效使用PVC，而是使用emptydir,这个问题在prometheus和loki上没有，这个问题很久就存在了，我改了几个地方就可以了 |
wonderflow
reviewed
Nov 29, 2024
| // +usage=Specify the storage size to use. If empty, emptyDir will be used. Otherwise pvc will be used. | ||
| storage?: =~"^([1-9][0-9]{0,63})(E|P|T|G|M|K|Ei|Pi|Ti|Gi|Mi|Ki)$" | ||
| // +usage=Specify the storage class to use. | ||
| storageClassName?: string | ||
| // +usage=Specify the admin user for grafana | ||
| adminUser: *"admin" | string | ||
| // +usage=Specify the admin password for grafana | ||
| adminPassword: *"kubevela" | string | ||
| adminPassword: *"admin" | string |
There was a problem hiding this comment.
can we keep the same password?
wonderflow
reviewed
Nov 29, 2024
| // +usage=Specify the imagePullPolicy of the image | ||
| imagePullPolicy: *"IfNotPresent" | "Never" | "Always" | ||
| // +usage=Specify the number of CPU units | ||
| cpu: *0.5 | number | ||
| // +usage=Specifies the attributes of the memory resource required for the container. | ||
| memory: *"1024Mi" | string | ||
| // +usage=Specify the service type for expose prometheus server. Default to be ClusterIP. | ||
| serviceType: *"ClusterIP" | "NodePort" | "LoadBalancer" | ||
| serviceType: *"NodePort" | "ClusterIP" | "LoadBalancer" |
There was a problem hiding this comment.
can we keep the same default type?
|
please sign DCO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
How has this code been tested?
Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml.README.md.