Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behavior in adding the Block Chomping Indicator to strings #5795

Open
duritong opened this issue Nov 4, 2024 · 1 comment
Open
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@duritong
Copy link

duritong commented Nov 4, 2024

What happened?

given the following structure:

$ cat configmap.yaml
kind: ConfigMap
apiVersion: v1
metadata:
  name: test
data:
  string: ''
---
kind: ConfigMap
apiVersion: v1
metadata:
  name: test2
data:
  string: ''
$ cat kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- configmap.yaml

patches:
- target:
    kind: ConfigMap
    version: v1
    name: test
  patch: |
    - op: replace
      path: /data/string
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

- target:
    kind: ConfigMap
    version: v1
    name: test2
  patch: |
    - op: replace
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

      path: /data/string

We get the following output:

$ kustomize version
v5.5.0
$ kustomize build
apiVersion: v1
data:
  string: |-
    this is
    a multiline string

    that should have an empty line at the end
kind: ConfigMap
metadata:
  name: test
---
apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test2

Although it seems we do have two times the same patch that we do get different results depending on whether we do have something after the string, that is still part of the path or not.

What did you expect to happen?

Both patches should produce the same output.

How can we reproduce it (as minimally and precisely as possible)?

# configmap.yaml
kind: ConfigMap
apiVersion: v1
metadata:
  name: test
data:
  string: ''
---
kind: ConfigMap
apiVersion: v1
metadata:
  name: test2
data:
  string: ''
# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- configmap.yaml

patches:
- target:
    kind: ConfigMap
    version: v1
    name: test
  patch: |
    - op: replace
      path: /data/string
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

- target:
    kind: ConfigMap
    version: v1
    name: test2
  patch: |
    - op: replace
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

      path: /data/string

Expected output

apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test
---
apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test2

Actual output

apiVersion: v1
data:
  string: |-
    this is
    a multiline string

    that should have an empty line at the end
kind: ConfigMap
metadata:
  name: test
---
apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test2

Kustomize version

5.5.0

Operating system

Linux

@duritong duritong added the kind/bug Categorizes issue or PR as related to a bug. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants