Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Unify structured logging for common operator #143

Open
Jeffwan opened this issue Jul 11, 2021 · 2 comments
Open

Unify structured logging for common operator #143

Jeffwan opened this issue Jul 11, 2021 · 2 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Jul 11, 2021

All of below have reference in different operators. This makes logs very messy and we need to consolidate to one common utility

  1. "github.com/sirupsen/logrus"
  2. "github.com/go-logr/logr" - default logger interface used by reconciler generated by kubebuilder.
  3. "sigs.k8s.io/controller-runtime/pkg/log" - implementation of "go-logr/logr"
  4. https://github.com/kubeflow/common/blob/master/pkg/util/logger.go - use logrus underneath
  5. "k8s.io/klog"
@Jeffwan Jeffwan changed the title Unify logging for common operator Unify structured logging for common operator Jul 11, 2021
@PatrickXYS
Copy link
Member

Do we have any preference in those log libraries? @Jeffwan

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 6, 2021

@PatrickXYS We do prefer json logging. No big preference. The challenge is different components use different solutions

  • kubebuilder
  • logrus

Let's see if we can consolidate into one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants