Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

apps.v1.deployment constructor match pods across deployments #152

Open
redbaron opened this issue Jul 11, 2018 · 0 comments
Open

apps.v1.deployment constructor match pods across deployments #152

redbaron opened this issue Jul 11, 2018 · 0 comments

Comments

@redbaron
Copy link

current defaults are pretty dangerous ,as they going to match pods across deployments:

new(name='', replicas=1, containers='', podLabels={ app: 'name' }):: apiVersion + kind + 
...
self.mixin.spec.template.metadata.withLabels(podLabels) + 
...

should be something like:

new(name='', replicas=1, containers='', podLabels=null):: apiVersion + kind + 
...
self.mixin.spec.template.metadata.withLabels(if podLabels != null podLabels else {app: name}) +
...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant