Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cross-domain-utils to typescript version #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update cross-domain-utils to typescript version #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
},
"dependencies": {
"@krakenjs/cross-domain-safe-weakmap": "^2.0.2",
"@krakenjs/cross-domain-utils": "^3.0.2",
"@krakenjs/cross-domain-utils": "^4.0.0-typescript.2",
"@krakenjs/zalgo-promise": "^2.0.0"
},
"lint-staged": {
Expand Down
2 changes: 1 addition & 1 deletion src/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
assertSameDomain,
type SameDomainWindowType,
type CrossDomainWindowType,
} from "@krakenjs/cross-domain-utils/src";
} from "@krakenjs/cross-domain-utils/dist/esm";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome to see! I really like how dist/esm provides the vanilla JS code for other deps to use while still supporting the existing tree shaking/dead code elimination strategy.

import { WeakMap } from "@krakenjs/cross-domain-safe-weakmap/src";

import {
Expand Down
2 changes: 1 addition & 1 deletion src/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* @flow */

import { ZalgoPromise } from "@krakenjs/zalgo-promise/src";
import { type SameDomainWindowType } from "@krakenjs/cross-domain-utils/src";
import { type SameDomainWindowType } from "@krakenjs/cross-domain-utils/dist/esm";

type RequestOptionsType = {|
url: string,
Expand Down