Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve point-cloud schema extraction #928

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Improve point-cloud schema extraction #928

merged 2 commits into from
Oct 30, 2023

Conversation

olsen232
Copy link
Collaborator

  • Use the real names and types of fields from the spec including, fix the incorrect sizes of <1 byte fields
  • Report individual flags as single bit fields (more like new PDAL does)
  • but don't actually use PDAL to learn the schema (since then we run into issues with the <1 byte field / at risk of future changes)
  • always return 1 of 7 hard-coded schemas if there is no extra bytes VLR (handles backwards incompatibility)
  • add a test to make sure we can read the extra bytes VLR if present

Related links:

#905

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

@olsen232
Improve point-cloud schema extraction
35d0cfc 
- Use the real names and types of fields from the spec
  including, fix the incorrect sizes of <1 byte fields
- Report individual flags as single bit fields (more like new PDAL does)
- but don't actually use PDAL to learn the schema
  (since then we run into issues with the <1 byte field / at risk of future changes)
- always return 1 of 7 hard-coded schemas if there is no extra bytes VLR (handles backwards incompatibility)
- add a test to make sure we can read the extra bytes VLR if present
@olsen232 olsen232 requested a review from craigds October 29, 2023 21:54
craigds
craigds approved these changes Oct 30, 2023
View reviewed changes
docs/pages/development/pointcloud_v1.rst Show resolved Hide resolved
kart/point_cloud/metadata_util.py Outdated Show resolved Hide resolved
kart/point_cloud/schema_util.py Outdated Show resolved Hide resolved
@olsen232 olsen232 merged commit 277f419 into master Oct 30, 2023
32 checks passed
@olsen232 olsen232 deleted the improve-point-cloud-schemas branch October 30, 2023 07:39
@olsen232 olsen232 mentioned this pull request Nov 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigds craigds craigds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olsen232 @craigds