Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renovate (again) #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sadlerap
Copy link
Collaborator

Let's try this again.

Let's try this again.

Signed-off-by: Andy Sadler <[email protected]>
renovate.json Outdated
@@ -3,11 +3,22 @@
"github>konflux-ci/mintmaker//config/renovate/renovate.json"
],
"enabledManagers": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I recall, all managers are enabled by default unless you specify enabledManagers. Unless you need something disabled, it might be easier to drop this clause.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of that, that would definitely be easier to manage. I'm used to dependabot, where you have to specify everything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's experimental, it's on by default, as far as I understand.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was pulling in https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json, maybe I don't need to, since I see it's disabling some managers that I would find useful here (gomod in particular).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted in b2a48e1.

Pulling from [konflux's mintmaker repository][1] explicitly might be
more trouble than it's worth for our needs.

[1]: https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json

Signed-off-by: Andy Sadler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants