-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix renovate (again) #25
base: main
Are you sure you want to change the base?
Conversation
Let's try this again. Signed-off-by: Andy Sadler <[email protected]>
renovate.json
Outdated
@@ -3,11 +3,22 @@ | |||
"github>konflux-ci/mintmaker//config/renovate/renovate.json" | |||
], | |||
"enabledManagers": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I recall, all managers are enabled by default unless you specify enabledManagers
. Unless you need something disabled, it might be easier to drop this clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of that, that would definitely be easier to manage. I'm used to dependabot, where you have to specify everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it's experimental, it's on by default, as far as I understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was pulling in https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json, maybe I don't need to, since I see it's disabling some managers that I would find useful here (gomod in particular).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted in b2a48e1.
Pulling from [konflux's mintmaker repository][1] explicitly might be more trouble than it's worth for our needs. [1]: https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json Signed-off-by: Andy Sadler <[email protected]>
Let's try this again.