Replay comment box visible #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify liveCommentView only not its config state.
|
i'm not sure why but this stops fetching comments for videos i access through recommendations. more specifically, if I go from one video to another, the comments don’t load for the second one (i have to refresh to make them load) if i remember correctly, i faced a similar issue when i tried to implement this in the past – i can take a deeper look soon! |
|
Huh, good catch :) That's strange. |
|
Does that have anything to do with this error? It's shown up before I've made any changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12 Hide the replay comment box when a video has no comments. But don't affect its config for other videos, like when toggling the view and a video has comments.