Allow libyaml 0.2 to pass tests, make build on architectures where it failed #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the project to build on architectures which define c_char as u8. Fixes build problems in architectures provided by debian.
|
Thanks for the fix! I didn't know 0.2 release came out. I'll check it out and see if I can continue to support 0.2.x release as it is. Until then, is it ok for you if I only merge the |
|
Of course it's ok for me. Thank you! |
|
I cherry-picked e526139 to master. I'd like to delay releasing another version until I review libyaml 0.2.x API. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit allows libyaml 0.2 to be used in addition to 0.1. This only affects the tests. As far as I can see, the libyaml 0.2 API is compatible to the degree that is used in this crate.
When working on Debian packaging, a small bug showed preventing builds on architectures which use u8 as c_char. https://buildd.debian.org/status/fetch.php?pkg=rust-yaml&arch=arm64&ver=0.3.0-1&stamp=1539200882&raw=0 shows one of the failed builds. This is fixed in the second commit.