New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cff: Broken number format checking in ParseDictDataBcd #211

Open

izbyshev opened this issue Jun 15, 2020 · 0 comments

Labels

izbyshev commented Jun 15, 2020

Svace static analyzer reported that the result of shift at

Line 219 in 5cbcf1b

nibbles[0] = (nibble & 0xf0) >> 8;

is always zero. Looks like 8 should be changed to 4.

The text was updated successfully, but these errors were encountered:

khaledhosny added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment