Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less rejecting, more sanitizing #18

Open
behdad opened this issue Jan 30, 2014 · 3 comments
Open

Less rejecting, more sanitizing #18

behdad opened this issue Jan 30, 2014 · 3 comments

Comments

@behdad
Copy link
Collaborator

behdad commented Jan 30, 2014

[This report is motivated by discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=964696 ]

When OTS was first born, it was to sanitize tables, ie. read them, and write back correct tables. Now that's a very hard task for many tables, so over time it started outright rejecting tables fairly broadly. I think we should try to address that. For example, the cmap table issue discussed in the above URL can easily be fixed by OTS instead of rejecting the font.

@khaledhosny
Copy link
Owner

I was thinking about this when looking into some other issues as well. Many things that we reject tables for can be simply fixed in the serialized table, the issue is that for most of the tables I looked into we have no code to construct new table data i.e. we either accept it as is or outright drop it, so that will be a bit of work.

@behdad
Copy link
Collaborator Author

behdad commented Jan 30, 2014

Yeah, understood.

@HinTak
Copy link

HinTak commented Aug 15, 2016

And sometimes, it may not be obvious in which way one should "fix" a broken table, especially automating such a process. rejecting any broken-ness is certainly easier to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants