Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS/Safari: Autofill works without TouchID and TouchID-windows still appears #376

Open
cryptosteve2 opened this issue Jul 6, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@cryptosteve2
Copy link

Description
I am unsure whether this is a bug or a misconfiguration. When selecting the autofill entry in Safari, in some cases the credentials are already filled in and then the TouchID window still appears. Logging in works regardless of whether Touch ID is still confirmed.

How to reproduce
Steps to reproduce the behavior:

  1. Go to the website
  2. Tap on Login
  3. Select the autofill entry

This happens on sites like https://www.zdf.de or https://www.abendblatt.de for example while it works as expected on github.com or https://write.tchncs.de/login

Expected behavior
Confirm Touch-ID and then fill in the credentials

Screenshots
On sites it does not work (here: https://www.zdf.de):
20240706@200909

while on this site is works as expected (here: https://write.tchncs.de/login):
20240706@201031

Environment:

  • Device: MacBook Pro 13-inch, M1, 2020
  • OS: MacOS 14.5 (23F79)
  • App Version: KeePassium Pro v1.52.151 Pro
@cryptosteve2 cryptosteve2 added the bug Something isn't working label Jul 6, 2024
@keepassium
Copy link
Owner

Thank you, @cryptosteve2 (and sorry for the delay).

I have another report about this issue, but could not reproduce it. The different behavior on different sites is a useful detail.

Can you also please share your App Protection timeout and first three options in the Data Protection settings?

@cryptosteve2
Copy link
Author

Hey,
App Protection timeout is set to "Immediately", and I also activate the option to "Lock on App launch".
At Data Protection I activated the option "Remember Master Keys", Database Timeout is set to "Never" and "Clear Master Keys on Timeout is activated too.

@blinskey
Copy link

This sounds like the same bug I described in a comment on #259. I'm seeing the same behavior that @cryptosteve2 described: autofill consistently works as expected on certain domains such as github.com but immediately fills before Touch ID authentication on other domains. My settings are the same as @cryptosteve2's.

I'd be happy to provide a list of domains where the bug does and does not occur via email if that would be helpful.

@igorkulman
Copy link
Contributor

Hi @cryptosteve2, I am trying to reproduce your issue but no luck so far. I am using the settings you described and https://www.zdf.de where I created an account. I am on macOS 14.6.1.

Here is a video of my attempt, if I do not use TouchID or password nothing gets filled in.

Screen.Recording.2024-08-27.at.15.04.14.mov

Are my steps different from your steps? Can you maybe provide a video instead of just screenshots?

I am also interested in knowing if you have Quick Autofill enabled in the app and if in macOS do you have just Keepassium or also iCloud Keychain or other apps enabled in the Password Options,

@cryptosteve2
Copy link
Author

cryptosteve2 commented Aug 29, 2024

Hi @igorkulman
My database is unlocked when trying to login ....

And yes, autofill is enabled. The following the options are enabled in the settings:

Quick Autofill
Fill-in Perfect Result Automatically
Copy OTP to Clipboard

In the MacOS settings I have only Keepassium Pro enabled, iCloud Keychain and Strongbox exists but are disabled.

@igorkulman
Copy link
Contributor

And yes, autofill is enabled. The following the options are enabled in the settings:

Does it work differently when the database is not unlocked? Or when the Keepassium app is not even running?

Asking because I still cannot reproduce, even with Quick Autofill enabled, database unlocked and all your other settings:

pwd.mov

@cryptosteve2
Copy link
Author

It makes no difference whether keepassium is running or not. In this video I skip fingerprint by pressing ESC ....

[email protected]

@keepassium keepassium reopened this Sep 8, 2024
@keepassium
Copy link
Owner

Sorry, false alarm, not fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants