Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the token-permission and pinned dependencies issue #6088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshitasao
Copy link

fixed the token-permission and pinned dependencies issue reported by scorecard.

Checklist

Part of #6085

@harshitasao harshitasao requested a review from a team as a code owner August 18, 2024 04:33
@@ -72,6 +72,7 @@ Here is an overview of all new **experimental** features:
### Fixes

- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
- **General**: Fixed the token-permission and pinned-dependencies issue reported by the scorecard. ([#6085](https://github.com/kedacore/keda/issues/6085))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's improve it to make it more clear.

Suggested change
- **General**: Fixed the token-permission and pinned-dependencies issue reported by the scorecard. ([#6085](https://github.com/kedacore/keda/issues/6085))
- **General**: Lock down GitHub token permissions ([#6085](https://github.com/kedacore/keda/issues/6085))
- **General**: Pin GitHub Action actions to specific version ([#6085](https://github.com/kedacore/keda/issues/6085))

Also, please move this under improvements as this is not a fix for KEDA itself

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the Other section please

Copy link

stale bot commented Dec 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants