Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differences in attribute formatting are not ignored #17

Open
h4l opened this issue Sep 23, 2019 · 0 comments
Open

Differences in attribute formatting are not ignored #17

h4l opened this issue Sep 23, 2019 · 0 comments

Comments

@h4l
Copy link

h4l commented Sep 23, 2019

This assertion fails:

const regularAttributes = `<foo c="3" a="1" b="2"></foo>`
    const wrappedAttributes = `\
<foo a="1"
     c="3"
     b="2"></foo>`
    expect(regularAttributes).toEqualXML(wrappedAttributes)
h4l added a commit to h4l/jest-xml-matcher that referenced this issue Sep 23, 2019
@h4l
Add failing test for wrapped attribute equivalence
de6bad6 
Demonstrates: kbiedrzycki#17
h4l added a commit to h4l/jest-xml-matcher that referenced this issue Sep 23, 2019
@h4l
Re-implement pre-diff XML formatting step
7e81457 
It's now more robust, pretty-data didn't normalise XML properly (e.g.
wrapped attributes were not normalised).

Now all whitespace is stripped and the document elements re-indented
(though respecting xml:space="preserve"). The XML is serialised with
C14N (https://www.w3.org/TR/2001/REC-xml-c14n-20010315) making it safe
to compare as character strings.

This fixes: kbiedrzycki#17
@h4l h4l mentioned this issue Sep 23, 2019
Open
mchesterkadwell pushed a commit to cambridge-collection/cudl-pack that referenced this issue Mar 3, 2021
@h4l
Fix XML comparison failing due to attribute indentation
faa317e 
There's currently a bug in jest-xml-matcher resulting it it treating
differences in indentation between XML files as content differences:
    kbiedrzycki/jest-xml-matcher#17

Until this is fixed the compared XML needs to have the same attribute
formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h4l