Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No probes for kanister operator #2998

Open
ifalex opened this issue Jul 25, 2024 · 2 comments
Open

No probes for kanister operator #2998

ifalex opened this issue Jul 25, 2024 · 2 comments

Comments

@ifalex
Copy link

ifalex commented Jul 25, 2024

Is your feature request related to a problem? Please describe.

One of best practice of a Pod is represented by having readines/liveness probes.
Is this something you would consider for kanister-operator deployment?

Describe the solution you'd like

Create readiness/liveness probes for kanister-operator if it makes sense. If it doesn't, provide explanation of why not supported/not needed.

Additional context

Many lint tools (kube-linter, kube-score) report this as critical issue.

Copy link
Contributor

Thanks for opening this issue 👍. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

@anishbista60
Copy link
Contributor

anishbista60 commented Sep 28, 2024

@pavannd1
IMO , we should go for using probes since the Many lint tools (kube-linter, kube-score) report this as critical issue and generally it is best practice to do so.

However, we do have some not doing aspect.

  • Operator doesnot need to have serve more traffic like traditional application. So, defination for probes might be differ here.
  • So on

I need the proper feedback from maintainer regarding should we use probe or not ? . So , that i can work in this Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Be Triaged
Development

No branches or pull requests

3 participants