New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes #1

Open

DinCahill wants to merge 2 commits into kalipare:master from DinCahill:some-fixes

DinCahill commented Mar 27, 2022

Hi, thanks for making this. I had to make some changes to get it to work for me on Windows.

Use go install instead of go get for golang 1.18 compatibility: https://go.dev/doc/go-get-install-deprecation
Only run the icon code if an icon was actually found.

Tested working on .lnk, .url without IconFile, and .url with IconFile.

DinCahill added 2 commits

March 27, 2022 15:53


          change go get to go install

5eeb58f


          check if an icon was found before using it

f404a20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet