Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shell completion for NP3 #226

Open
jkowalleck opened this issue Apr 19, 2020 · 1 comment
Open

fix shell completion for NP3 #226

jkowalleck opened this issue Apr 19, 2020 · 1 comment
Labels
Milestone

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Apr 19, 2020

TL;DR: fix shell completion for version 3.
its currently disabled for a reason.


in upcoming verrsion 3 of nichtparasoup
the CLI will probably be driven via click instead of argparse

unfortunately click has a broken feature for shell autocompletion in version 7.

see also: pallets/click#1622

it's fortunate that this will be fixed in version 8 - as far as the milestones give insignt.

an intermediate fix fia click_completion is incomplete, too: file completions are not working.

@jkowalleck jkowalleck added the bug label Apr 19, 2020
@jkowalleck jkowalleck added this to the 3.0.0 milestone Apr 19, 2020
@jkowalleck jkowalleck changed the title fix shell completion fix shell completion for NP3 Apr 19, 2020
@jkowalleck
Copy link
Member Author

there was an attempt to use alternative click completion, already.
see https://github.com/k4cg/nichtparasoup/blob/218cc230024aa34facd8fc2e237b22ae8b639245/src/nichtparasoup/cli/completion._py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant