Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable BIP32 derivation paths #12

Open
justinmoon opened this issue Aug 29, 2019 · 4 comments
Open

Allow configurable BIP32 derivation paths #12

justinmoon opened this issue Aug 29, 2019 · 4 comments

Comments

@justinmoon
Copy link
Owner

No description provided.

@dasource
Copy link

dasource commented Sep 2, 2019

FYI - below paths should give fairly good compatibility with other multisig implementations.

Legacy (P2SH) m/45'/0/0/0
Segwit Compatibility (P2WSH-P2SH) m/48'/0'/0'/1'
Native Segwit (P2WSH) m/48'/0'/0'/2'

@justinmoon
Copy link
Owner Author

justinmoon commented Sep 2, 2019 via email

@Sjors
Copy link

Sjors commented Sep 4, 2019

I wouldn't necessarily make them configurable, but they definately should follow the some standard. In addition to what @dasource points out for address type (44/49/84), receive should use ...0/n and change should use .../1/n. It currently uses 0 for both.

It does seem to correctly get "married" paths, i.e. the same derivation for each device. You may also want to sort by fingerprint. I'm not at all up to date on good conventions though. Maybe @instagibbs has some ideas?

@justinmoon
Copy link
Owner Author

@Sjors Correct. I haven't implemented change addresses yet. Configurable BIP32 paths would really only be useful if Junction is used as a recovery tool. Definitely not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants