-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed wrapspawner to allow selection of image #545
Comments
Thank you for opening this issue, @gsemet! I agree that it would be very useful to have! I think adding something like jupyterhub/dockerspawner#219 to github.com/jupyterhub/kubespawner is a better fit! What do you think, @minrk? |
I'd like to help out, even if that is just being a guinea pig on this ticket |
Isn’t it easier or better to integrate wrapperspawner in zero to jupyterhub or hack into kubespawner? |
@yuvipanda If I follow you proposal to hack into kubewrapper, I would like to propose the following change in kubewrapper:
Note that Or maybe we can be more agressive:
This would allow extension in the future, such as adding a logo (base64 or url or image id) to have a better looking profile selection (like the welcome panel in jupyterlab). |
indeed, adding wrapperspawner support may be the best way to go. |
I have made a proposal in this PR: jupyterhub/kubespawner#137 |
Has this functionality been merged into the z2jh deployment yet? If not and we want to implement this, what is the best way to approach this? |
I think the kubespawner profiles are now in z2jh |
Closed thanks to @gsemet's work on jupyterhub/kubespawner#137! |
Hello
How hard would it be to embed wrapspawner or similar in order to allow user selection of desired profile upon connection.
What I mean by "profile" is a predefined list of "image + cpu number + disk space + memory".
I imagine something like a dropbox where user can select for instance"small datascience notebook", "big memory datascience" or "Python training notebook", and so on, and it would launch the related image and cpu/memory request for kube.
The text was updated successfully, but these errors were encountered: