Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist pvc name and/or uid in state for template changes #415

Open
minrk opened this issue Jul 3, 2020 · 3 comments
Open

persist pvc name and/or uid in state for template changes #415

minrk opened this issue Jul 3, 2020 · 3 comments

Comments

@minrk
Copy link
Member

minrk commented Jul 3, 2020

pod_name_template and pvc_name_template are configurable string templates that identify objects, e.g. with jupyter-username, but they are customizable to e.g. otherthing-username. Currently, we only use these strings to resolve resources such as pods, pvcs, etc., not the persistent, unique uid of those objects. A problem arises when a deployment might want to change these templates without destroying everything. We currently load pod_name from state, which means we should recover running pods across Hub restart with changing pod_name_template. However, changing pvc_name_template will result in orphaned user data. We should persist and restore pvc_name in state if in use like we do for pod_name, but perhaps it would be even better to persist uids instead of names?

@manics
Copy link
Member

manics commented Jul 3, 2020

jupyterhub/dockerspawner#384 is another use-case for storing this info as state- it would allow a modified idle-culler to remove a volume without needing access to the spawner config or jupyterhub_config.py.

@meeseeksmachine
Copy link

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/a-cull-idle-user-service-that-deletes-pvs/4742/14

@meeseeksmachine
Copy link

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/a-cull-idle-user-service-that-deletes-pvs/4742/16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants