Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image selection dropdown not rendering #164

Closed
jgerardsimcock opened this issue Apr 23, 2018 · 2 comments
Closed

Docker image selection dropdown not rendering #164

jgerardsimcock opened this issue Apr 23, 2018 · 2 comments

Comments

@jgerardsimcock
Copy link

I am running a deployment that is based on the "v0.7-4c22c3d " jupyterhub helm-chart. I am trying to add additional docker images to my notebook for my users following the merge of #137 . From my understanding, I just add c.KubeSpawner.profile_list to the extraConfig and specify the images I want to use? Am I missing anything?

hub:
    extraConfig: |
      from kubernetes import client
      def modify_pod_hook(spawner, pod):
          pod.spec.containers[0].security_context = client.V1SecurityContext(
              privileged=True,
              capabilities=client.V1Capabilities(
                  add=['SYS_ADMIN']
              )
          )
          return pod
      c.KubeSpawner.modify_pod_hook = modify_pod_hook
      c.JupyterHub.logo_file = '/usr/local/share/jupyter/hub/static/custom/images/logo.png'
      c.JupyterHub.template_paths = ['/usr/local/share/jupyter/hub/custom_templates/',
                                    '/usr/local/share/jupyter/hub/templates/']

      c.KubeSpawner.profile_list = [
        {
        'display_name': 'Dask-Hub - Python',
        'kubespawner_override': {
            'singleuser_image_spec': 'rhodium/notebook:2018-04-17',
        }
        },
        {   
        'display_name': 'R Notebook',
        'kubespawner_override': {
            'singleuser_image_spec': 'civisanalytics/datascience-r:latest',
        }
        }
        ]
@clkao
Copy link
Contributor

clkao commented Apr 23, 2018

Did you update the kubespawner rev listed in z2jh's images/hub/requirements.txt?

@jgerardsimcock
Copy link
Author

jgerardsimcock commented Apr 23, 2018

Thank you @clkao

after adding the requirements.txt file we'll also need to update our Dockerfile with the lines below and then redeploy our helm chart:

ARG JUPYTERHUB_VERSION=0.8.*

ADD requirements.txt /tmp/requirements.txt
RUN pip3 install --no-cache-dir \
         jupyterhub==${JUPYTERHUB_VERSION} \
         -r /tmp/requirements.txt

Do I understand this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants