Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SpawnerForm that lets you pick which Image to run #14

Closed
yuvipanda opened this issue Nov 15, 2016 · 7 comments
Closed

Comments

@yuvipanda
Copy link
Collaborator

For feature parity with https://github.com/sveesible/jupyterhub-kubernetes-spawner.

@elgalu
Copy link

elgalu commented Oct 18, 2017

@sveesible would you be willing to back port upstream your customizations to allow SINGLEUSER_IMAGE be chosen from a fixed list?

@elgalu
Copy link

elgalu commented Oct 18, 2017

Implementation wise, what I'm thinking now is: instead of having one single Start My Server is to iterate over a list and have one button for each image, e.g. Start my {image-name} notebook.

To achieve that I was thinking about adding a new singleuser_image_spec_list simil to singleuser_image_spec. It's an idea more aligned to c.DockerImageChooserSpawner.dockerimages

@keithcallenberg
Copy link
Contributor

@elgalu I like the idea of singleuser_image_spec_list but could it default to displaying as a drop-down? I think many users have more than just a few images, which would make buttons impractical.

FWIW, I've been running something similar to @sveesible 's KubeOptionsSpawner in a team environment for a month now and it has been working great. Some documentation with examples of overloading KubeSpawner might reduce the need to bake these customizations in.

@elgalu
Copy link

elgalu commented Oct 18, 2017

I've been running something similar to @sveesible

Could you open source it?

@sveesible
Copy link

sveesible commented Oct 18, 2017 via email

@jlewi
Copy link

jlewi commented Apr 2, 2018

This is what Kubeflow does.
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/jupyterhub_spawner.py

I think we are doing the Jupyterhub interface pattern as @sveesible mentions above.

@yuvipanda
Copy link
Collaborator Author

Fixed in #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants