Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository status #4

Open
antecrescent opened this issue May 21, 2024 · 2 comments
Open

Repository status #4

antecrescent opened this issue May 21, 2024 · 2 comments

Comments

@antecrescent
Copy link
Contributor

antecrescent commented May 21, 2024

Since your wiki page on the LXD testing setup is now archived, I assume this repo will be archived, too?

From what I can tell, the container scripts and settings are largely duplicated across this repo and incus-gentoo-github-pullrequest-tester.
Would it be an idea to merge both repos and add separate directories/logic for the {incus,lxd}-host?

Thank you for sharing your testing setup and thanks for the wiki pages!

@juippis
Copy link
Owner

juippis commented May 21, 2024

Hey,

indeed I've been meaning to archive this GH page in favor of the incus one, but your suggestion does make sense. As you probably can see, all the incus-host scripts have the word "incus" in them, and that's precisely because for a moment I had both incus and lxd installed and had to differentiate the scripts somehow. So I updated these scripts locally to say "*lxd*" too. I actually intended to keep lxd around installed, too, but everything works so fine with incus here I never went back to lxd after all. So yeah, I should've archived this some time ago now.

But your suggestion makes sense (and I saw your PR on the prtester.sh script) so I'll think about fusing these two repos - thanks for the PR, it'll get merged for sure after testing!

@antecrescent
Copy link
Contributor Author

Thank you for taking interest in the PR! Whatever you end up doing with the test suites, I'll probably stick around, because they works quite well for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants