Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hero: allow hero diagonal movements #76

Closed
3 tasks done
jorgegv opened this issue Jul 29, 2022 · 1 comment
Closed
3 tasks done

hero: allow hero diagonal movements #76

jorgegv opened this issue Jul 29, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jorgegv
Copy link
Owner

jorgegv commented Jul 29, 2022

The hero cannot move diagonally, but it would be nice.

This would add 4 more directions for movement (besides UDLR), but sprites and animation sequences could be reused from the other directions (e.g. horizontal LR animations)

Tasks:

  • Allow diagonal movement
  • Modify collision detection for the new movement cases
  • Fix bug in animation sequences:
    • Move right (press RIGHT), keep it and then move down (press DOWN) at the same time, then release DOWN, keep moving right. The animation sequence at this point should be RIGHT, but instead it is DOWN.
    • The same happens when moving LEFT
    • The same happens if you move UP while LEFT or RIGHT: sequences should be LEFT or RIGHT, but they are UP instead
    • The problem is reset if you start moving horizontally on the opposite direction

Enhancements to diagonal movevents are tracked in #80

@jorgegv jorgegv added the enhancement New feature or request label Jul 29, 2022
@jorgegv jorgegv added this to the Release 0.5.0 milestone Jul 29, 2022
@jorgegv jorgegv self-assigned this Jul 29, 2022
@jorgegv jorgegv changed the title hero: allow diagonal movement hero: allow hero diagonal movements Aug 6, 2022
@jorgegv jorgegv closed this as completed Aug 6, 2022
@jorgegv jorgegv reopened this Aug 6, 2022
@jorgegv
Copy link
Owner Author

jorgegv commented Aug 6, 2022

Reopened for fixing diagonal animation sequences

@jorgegv jorgegv closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant