Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding jruby-truffle.jar breaks on Windows #9

Open
jkutner opened this issue Aug 11, 2015 · 7 comments
Open

Adding jruby-truffle.jar breaks on Windows #9

jkutner opened this issue Aug 11, 2015 · 7 comments

Comments

@jkutner
Copy link
Owner

jkutner commented Aug 11, 2015

The org/jruby/Main class can't be found when truffle is on the boot classpath.

@jkutner
Copy link
Owner Author

jkutner commented Sep 2, 2015

@chrisseaton
Copy link

Truffle doesn't work on Windows due to some JNR calls we do - but that doesn't explain what would cause this problem.

Is there more error output? It might be more complex than simply 'not found'.

@jkutner
Copy link
Owner Author

jkutner commented Sep 9, 2015

No matter how I twist this around, I still get NULL returned from the JNI call to FindClass. Effectively:

jclass main_class = (*env)->FindClass(env, "org/jruby/Main");

@chrisseaton any ideas here?

@chrisseaton
Copy link

What I'm still not sure about is does removing Truffle from the class path completely solve the problem for you?

@jkutner
Copy link
Owner Author

jkutner commented Sep 9, 2015

@chrisseaton yes. i just toggle this line: https://github.com/jkutner/mjruby/blob/master/mrblib/jruby_support.rb#L73

only happens on Windows. I've tried reordering the jars on the classpath. no change. I'm mainly searching for a way to get more info, not necessarily a solution.

I could also exclude the truffle JAR from the boot classpath if I detected that it's windows. Would that be ok?

@chrisseaton
Copy link

Can I just suggest you keep Truffle off the bootclasspath for now then and we'll treat Truffle as an unsupported feature in the new launcher for now?

I'd have to reproduce to do anything more helpful, which would mean setting up a Windows dev environment that I don't immediately have. I will add it to my todo list but can't promise anything.

It is certainly a strange bug. Truffle may seem like magic but jruby-truffle.jar doesn't include anything weird like our JIT compiler - it's just Java code with the exception as the same JNR stuff that normal JRuby uses.

@jkutner
Copy link
Owner Author

jkutner commented Sep 9, 2015

@chrisseaton yea, i think leaving it off the path is perfect for. i just wasn't sure if that was ok. we can deal with this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants