-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commas are generating warnings #347
Comments
thanks for reporting this! will be fixed in the next release. |
so it's fixed: however, if a comma appears in one field definition all fields are marked (note the last field with comments): please note that you can also disable linting warnings by putting at the very first line of your JDL a comment as follows:
or
one more thing, do not use commas as they will be removed in the near future (see also) |
* migration * solves #347 * versioning * fixed version and deps. fixed an npe
That's a fast fix! :-) I think that if commas will be removed in the next release, then there will be introduced a new warning telling to not use them in field definitions, so that would solve the last problem you reported. But disabling linting wouldn't disable it for all rules? |
Describe the bug
When opening a JDL in VS Code, a comma inside of a comment will cause a warning to show up with "Useless commas can be removed" as the cause.
Exporting a JDL with the
jhipster export-jdl
command, generates comma separated fields in entities, and fields are highlighted as warnings too (same reason).To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
Different situations that are causing warnings to show up (or not)
Desktop (please complete the following information):
Additional info
I suppose that comments are being parsed with the same rule-check used for comma separated fields. That souldn't happen!
The text was updated successfully, but these errors were encountered: