Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude testscripts from Flake build #2426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamdicarlo
Copy link

@adamdicarlo adamdicarlo commented Nov 30, 2024

This stops including a potentially-colliding 'updater' binary in the derivation.

Summary

When I tried to install Zen browser on my NixOS system via a flake (zen-browser.url = "github:MarceColl/zen-browser-flake";), I got a build error saying that zen-browser included a file that collides with a devbox file:

error: builder for '/nix/store/8fy82p10qwd7z5aj4sraq9k88c62nz55-home-manager-path.drv' failed with exit code 25;
       last 1 log lines:
       > error: collision between `/nix/store/915ll44ksnhy369wyqlm8ys7ylxzmi89-devbox-0.13.6-0bc66cb/bin/updater' and `/nix/store/s2bz22csj1a8yjh3n3i1h67s5zhrh1g2-zen-browser-1.0.1-a.6/bin/updater'

My guess is that the zen-browser flake is also at fault (also errantly including a binary named updater) but this is where I looked (and figured out how to fix) first.

How was it tested?

Re-ran the build via nix build . and verified that ./result/bin/ now contains only devbox. (It used to also contain a 1.7MB file called updater.)

This stops including a potentially-colliding 'updater' binary in the derivation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant