Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeStyle Project Plugin #4206

Open
slide opened this issue Nov 28, 2024 · 12 comments
Open

FreeStyle Project Plugin #4206

slide opened this issue Nov 28, 2024 · 12 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@slide
Copy link
Contributor

slide commented Nov 28, 2024

Repository URL

https://github.com/slide/freestyle-project

New Repository Name

freestyle-project-plugin

Description

This is a breakout of the FreeStyle project from Jenkins into a plugin.

GitHub users to have commit permission

@slide

Jenkins project users to have release permission

slide_o_mix

Issue tracker

Jira

@slide slide added the hosting-request Request to host a component in jenkinsci label Nov 28, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.31.144)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Nov 28, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: You must add a 'groupId' in your pom.xml with the value io.jenkins.plugins.
  • ⛔ Required: The pom.xml file in the root of the origin repository is not valid
  • ⛔ Required: Please add a license file to your repo, GitHub provides an easy mechanism to do this from their user interface.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Nov 28, 2024
@slide
Copy link
Contributor Author

slide commented Nov 28, 2024

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Nov 28, 2024
@timja
Copy link
Member

timja commented Nov 28, 2024

@jglick any thoughts on this?

@daniel-beck
Copy link
Contributor

@core should be co-maintainers IMO.

@timja
Copy link
Member

timja commented Nov 28, 2024

Not sure if the checks will handle that but can be added at hosting time

@timja
Copy link
Member

timja commented Dec 2, 2024

/hosting host

@slide
Copy link
Contributor Author

slide commented Dec 2, 2024

I will follow-up with a PR to core to make the plugin detached.

@timja
Copy link
Member

timja commented Dec 2, 2024

/hosting host

1 similar comment
@timja
Copy link
Member

timja commented Dec 2, 2024

/hosting host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

4 participants