-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edit this page link #556
Comments
Can I do this? @timja |
if the goal is just to have the same link in two places, this should be quite straightforward. If we want the actual link for editing the readme, the hard part is to figure out which file it is -- it may be README.md / README.txt / README.adoc, not sure how to efficiently get it from GitHub API. Also at the moment all queries to GH API are in the |
@zbynek May I work on this issue? |
Sure, let us know if you need a hand or unable to work on it |
@timja do you have any idea how to get the correct link from GitHub API? |
You can get it from this: https://api.github.com/repos/jenkinsci/theme-manager-plugin/readme?ref=master |
Any update on this issue? |
what update are you expecting? |
The implementation part is it needs to be done? |
It's still a valid issue, IMHO not a high priority though. The question is how to best find location of the README in repository. It's possible to do that with rest API, but that means 1 request per repository. Since plugin-site repo doesn't have credentials for GitHub API that would have to be exposed through API of some other component, such as https://github.com/jenkins-infra/docker-plugin-site-issues . One could ask GitHub developers to add it to the GraphQL API so that it can be obtained for 100 repos in one query. Or just try the 2-4 most common locations. Currently #961 implements the last approach. |
is this still to be done? if so let me know where i can found |
We currently have:
It would be good to add an 'Edit this page' or 'Improve this page' link next to report a problem so you can go directly to the GitHub edit page screen from the plugin site
The text was updated successfully, but these errors were encountered: