Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing adopt-this-plugin topic on maintainer-less plugins repository #3580

Open
alecharp opened this issue May 12, 2023 · 6 comments
Open

Comments

@alecharp
Copy link

Hello,

I've been looking at the plugins marked as to be adopted and found that we are missing some. Let me explain, some plugins don't have any developers listed in their permission files and their repository doesn't have the adopt-this-plugin topic. For those, I believe that we should add the adopt-this-plugin topic on the repository, to be fair with users and potentially find new person to maintain the plugin.

Here is the list of plugins I gathered:
@NotMyFault
Copy link
Member

For those, I believe that we should add the adopt-this-plugin topic on the repository, to be fair with users and potentially find new person to maintain the plugin.

If visibility is a concern, the plugin site should display the adoption banner, if the developer list is empty.
Manually (and retrospectively) adding the topic to every repository may address the issue for now, but isn't future-proof.

@alecharp
Copy link
Author

Good point.
The banner is coming from the fact that the topic appears in the update-center.

I guess we could tweak the update-center to use the fact that the list is empty to assume the plugin is up for adoption.

@MarkEWaite
Copy link

I really like the idea of having the plugins site display the adoption banner if the list of developers is empty. If the update center can be extended to automatically declare that a plugin is up for adoption if its developer list is empty, that sounds great to me.

@alecharp
Copy link
Author

alecharp commented May 12, 2023

If I'm not mistaken, the plugin site uses the labels value of the update-center entry, which are the topics of the GH repository.

Also, the plugin-health-scoring is currently using that labels list to specify of a plugin is up for adoption or not. Having the 'empty developers list means up for adoption' logic on the update center directly would solve the problem everywhere.

@alecharp
Copy link
Author

To be fair, I think having the topic on the repository would also be a good addition, as if someone wants to adopt a plugin, that person might browse the adopt-this-plugin filtered list (https://github.com/search?q=topic%3Aadopt-this-plugin+org%3Ajenkinsci+fork%3Atrue&type=repositories) which is on the root page of the jenkinsci organization.

Adding the label on the repositories I listed is not future proof, but this can also be a one time thing as we can update the pull request template on the RPU repository to specify that when removing the last entry of the developers list, that person must add the topic on the repository before we merge the pull request.

@daniel-beck
Copy link

daniel-beck commented May 12, 2023

I don't think Daniel favors that approach ;)

Fine with me (see jenkins-infra/update-center2#654), but blocked by jenkins-infra/repository-permissions-updater#2911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants