Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin-site chart issues: github.appId is required & jira.username is required #660

Open
lemeurherve opened this issue Sep 6, 2023 · 6 comments
Labels

Comments

@lemeurherve
Copy link
Member

helm template plugin-site output:

Error: execution error at (plugin-site/templates/secret.yaml:10:20): github.appId is required

Error: execution error at (plugin-site-issues/templates/secret.yaml:11:20): jira.username is required

Unit tests should be added, doc: https://github.com/helm-unittest/helm-unittest/blob/main/DOCUMENT.md

@bhavyastar
Copy link

Hey, I would like to work on this issue.

@dduportal
Copy link
Contributor

Hey, I would like to work on this issue.

No problem, please proceed. You might be interested into checking what was done for other issues of this kind, such as #725.

@dduportal dduportal added hacktoberfest Participate to hacktoberfest hacktoberfest-accepted labels Oct 16, 2023
@bhavyastar
Copy link

Yes, I had a look at all of these issues. I understand the issue, and after making a draft pull request you can tell me if there are necessary changes that need to be made. Is that okay?

@ashwin1596
Copy link

Hi,

I am interested in working on this issue if it is still open and a PR hasn't already been raised. Could you please confirm if I can start working on it?

Thank you!

@dduportal
Copy link
Contributor

Hi,

I am interested in working on this issue if it is still open and a PR hasn't already been raised. Could you please confirm if I can start working on it?

Thank you!

yes you can. Don't forget to check #725 before

@ashwin1596
Copy link

@dduportal, I reviewed ticket #725, where the problem was that the values were initially null but needed to be strings. This was resolved by setting them to "". However, the current error indicates that these fields are still mandatory despite containing "". Should we ensure they have non-empty strings, or is there a specific adjustment needed in secret.yaml? Could you advise on the next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants