Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Jenkins logo text redirects to jenkins.io on click #118

Conversation

krisstern
Copy link
Member

Fixes jenkins-infra/contributor-spotlight#42

Redirects users to https://www.jenkins.io/ instead of root / upon their clicking of the Jenkins logo text.

c.c. @kmartens27 @MarkEWaite @alyssat @jmMeessen @gounthar

Copy link

@alyssat alyssat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @krisstern for this improvement

@halkeye
Copy link
Member

halkeye commented Dec 14, 2023

I swore i replied to this. I have concerns that all sites will have their "home" button now goto a different site. On plugins.jenkins.io it'll no longer goto the front search page. I'm not going to block it, butI think it needs discussion.

@NotMyFault NotMyFault self-requested a review December 14, 2023 23:19
@MarkEWaite
Copy link
Contributor

I'm a little surprised at the approval from @NotMyFault since I thought that he preferred the current behavior.

I'm torn between current behavior (link to '/') and the proposed new behavior (link to 'https://www.jenkins.io'). We discussed in documentation office hours today and @gounthar and I were both open to either direction.

@alyssat prefers the change in this pull request so that the clicking the top left Jenkins icon from contributors.jenkins.io or stories.jenkins.io will take the reader to the www.jenkins.io page. I think that more discussion is needed. Is there a common behavior that can be referenced from other sites?

@NotMyFault
Copy link
Member

NotMyFault commented Dec 15, 2023 via email

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Home should go to the current site

@kmartens27
Copy link
Contributor

I feel as though keeping the current functionality makes sense, since it is across all jenkins.io sites and otherwise would lead users away from what they are currently on. This result could be unexpected and unwanted for those on the plugins site or contributors site.

@timja
Copy link
Member

timja commented Dec 15, 2023

I think that more discussion is needed. Is there a common behavior that can be referenced from other sites?

I think the Kubernetes site may be similar but when you are on another area of the site they clearly highlight which one you are on so you can get back to the root of that one.

https://kubernetes.io/training/

image

@halkeye
Copy link
Member

halkeye commented Dec 19, 2023

I think that more discussion is needed. Is there a common behavior that can be referenced from other sites?

I think the Kubernetes site may be similar but when you are on another area of the site they clearly highlight which one you are on so you can get back to the root of that one.

https://kubernetes.io/training/

image

yea that was one reason I wrote this in the first place. Trying to implement that logic in all the custom html on jenkins.io was frustrating. The javascript version in this component isn't perfect, but its a step in the right direction. Unfortuately it loses the highlighting for sub pages. I had to only highlight for exact matches because prefix matching was breaking too easily.

@krisstern krisstern closed this Nov 28, 2024
@krisstern
Copy link
Member Author

Not planned

@krisstern krisstern deleted the feat/make-jenkins-logo-text-redirects-to-jenkins-io-on-click branch November 28, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Jenkins text logo navigation
7 participants