-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around problems with flattened pom #95
Work around problems with flattened pom #95
Conversation
Thanks so much for this! I think that the Jenkinsfile needs to be switched to run Unfortunately, that didn't fix it either. Now trying build 4 with the artifact caching proxy definition removed. |
Build 4 completed successfully. The zip file that is generated includes many more entries than are displayed on the current index page. I've started a build 5 that uses the artifact caching proxy without the authentication content. Build 4 took 2 hours to complete. Hopefully build 5 will be faster and less burdensome on the artifact repositories. |
I know someone (@gounthar) that is very skilled with updatecli manifests. I can likely persuade him to write the mianifest that will keep that up to date. |
Not an unqualified success: A lot of projects seem to have HTTP repository URLs in their poms, which recent(ish) Maven releases block.
|
As I wrote, probably better done with code reorg once we know this approach isn't doomed to fail. Wild guess so far: This will not work for any plugin with implied dependencies it actually uses (but might only result in fewer extensions discovered, unsure). |
…or repo definitions
😊 |
Sorry accidentally pushed it your branch meant to be my fork. I'll finish testing but something like this should work. |
"dependency:copy-dependencies", | ||
"org.apache.maven.plugins:maven-dependency-plugin:3.8.0:copy-dependencies", | ||
"org.apache.maven.plugins:maven-dependency-plugin:3.8.0:copy", | ||
"-Dartifact=org.jenkins-ci.main:jenkins-core:2.479", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in timja-org#3
could revert back to 2.480 although this will demonstrate it working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting #95 (comment) for visibility just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 67785f7
created #96 |
This now looks a lot better than before. Some content is missing or seemingly wrong compared to master (super old, its content pre-dates 2.421, as
So with one obsolete plugin ( While I'd like to confirm the guess in #95 (comment) this seems mergeable anyway, any further improvements can be done as followup after the extensions index is restored. |
Filed as jenkins-infra/helpdesk#4342 |
Not a long-term fix, at minimum we would need to keep updating to the latest weekly. A little code reorg can probably easily take care of the problem by passing in the previously downloaded core, but right now I'm looking for confirmation that the
dependency:copy
approach works.Attempts to address #58 (not using a magic term due to uncertainty).
Since repo.jenkins-ci.org no longer proxies all of central, I needed to change the included
settings.xml
to make this work for me.Seems to have worked reasonably well with a fairly small JSON locally, now waiting for PR build result.
cat update-center.actual.json