Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezor One MPMA support #124

Open
Skept0x opened this issue Apr 29, 2023 · 2 comments
Open

Trezor One MPMA support #124

Skept0x opened this issue Apr 29, 2023 · 2 comments

Comments

@Skept0x
Copy link

Skept0x commented Apr 29, 2023

Adding MPMA support for Trezor One (The third most important function for hardware wallets after send and sweep).
Currently, Trezor One users are forced to either send assets one by one, or sweep them all.

Prompt after attempting an MPMA using Trezor One:
"Checking data encoding fees on send..."

Screenshot 2023-04-29 at 15 02 17

@B0BSmiths
Copy link

B0BSmiths commented Nov 3, 2023

I have found the signing of the second TX in a multisend is problematic on Trezor. The Trezor sees the OP return but it ignores the PS2H encoded inputs. It then consumes and an entire UTXO on mining fees as there is no change in the TX and broadcasts the op return without signing the P2SH encoded inputs, so an unrelated entire utxo is consumed and your multisend fails

@jdogresorg
Copy link
Owner

similar issue as #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants