Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify of fees on sign raw transaction #119

Open
jdogresorg opened this issue Mar 29, 2023 · 2 comments
Open

Notify of fees on sign raw transaction #119

jdogresorg opened this issue Mar 29, 2023 · 2 comments

Comments

@jdogresorg
Copy link
Owner

jdogresorg commented Mar 29, 2023

When signing a raw transaction, we should notify / confirm action with user before broadcasting tx.

Notify user of the following :

  • BTC Miners fee
  • Data encoding costs
  • Total amount being spent in tx = (sum(input.value) - miner_fee)

image

@jdogresorg
Copy link
Owner Author

coded up a BTNS decoder, which also decodes counterparty transactions into the raw data...

https://github.com/jdogresorg/BTNS-Decoder

Use this library to decode what the transaction is trying to do and confirm it with the user.

@jdogresorg
Copy link
Owner Author

jdogresorg commented Sep 19, 2023

Partially addressed by commit 4febac6 by decoding any XCP data and confirming with user.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant