-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Adds explanation of the '~' character to networking.istio.io/exportTo annotation #3371
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome @gbucknel! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @gbucknel. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -47,7 +47,7 @@ annotations: | |||
featureStatus: Alpha | |||
description: Specifies the namespaces to which this service should be exported to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the doc
comma-separated list namespace names can be specified
to the above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to find out who our company's CLA manager is...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@gbucknel: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I couldn't see any explanation of what the '~' character does for this annotation , but it seems like it is supposed to set visibility to nothing:
https://github.com/istio/istio/blob/055e235292052c100688def4bee9c63b3fab830c/pilot/pkg/serviceregistry/kube/conversion_test.go#L305
https://istio.slack.com/archives/C37A4KAAD/p1728324326776739?thread_ts=1728036926.260279&cid=C37A4KAAD