IRCV3BEARER SASL mechanism for bearer tokens #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
slingamn
changed the title
kylef
reviewed
May 28, 2024
kylef
reviewed
May 28, 2024
|
|
||
| ## Examples | ||
|
|
||
| This is an example of successful authentication with the `jwt` bearer token type: |
There was a problem hiding this comment.
Presumably the token type is opaque to the client and an implementation detail of the server and/or IdP? The client is merely a bearer of a token, what it is isn't important for it.
Therefore I'd perhaps not call out that it is a JWT token specifically here.
There was a problem hiding this comment.
A precedent for what I'm trying to do here is the "token type hint" as defined by RFC 7662:
- This is a hint to the server to speed up recognition of the token; if the hint is not recognized, the server can fall back to exhaustive search over all possibilities for validating the token, although this may be undesirable for performance reasons
- Although the hint may be implementation-defined, it is preferable that it be registered: here's the registry for OAuth token type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #534, incorporating feedback received there:
IRCV3BEARERinstead of reusingPLAINIRCV3BEARERstill overlaps withOAUTHBEARER, but it's more general, since it supports arbitrary bearer token types including JWTs