-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
userip-tag and userhost-tag #418
Comments
I actually came up with this (*) idea in 2017 and made an issue about it in the inspircd repository because I have a need for this for our non-opered bots (and non-opered staff) to still be able to do their jobs properly. Edit: (*) Not exactly THIS idea with tags, but, yeah. |
@Robby- Yeah, sending real hosts or IPs to certain groups has come up once in a while before. I even have a closed feature suggestion from 2003 about it. In MS Exchange (IRCX) it already showed realhost to chanops, so years before that. I think it was in Exchange 5.5 already but it could also have been Exchange 2000. (Side note: exposing uncloaked hosts to normal chanops is something I really disliked, and I think I misread the 2003 suggestion which was actually about ircops) Anyway, you have read about the downsides and complexity that makes altering the message source highly unfavorable. I see you mention the same downsides and call it opening a can of worms, which is entirely correct. |
Why do the tags repeat the username? I'd have thought it cleaner just to send the host or IP. |
I have to say I agree with @edk0 on this, if we really need to include the username it should be a separate tag so as to not repeat the username more then once. Otherwise it just becomes repeated data taking up message space. |
Sure, we can scratch the username part and change the tag names accordingly, like to |
This is a non-official implementation of UnrealIRCd's userhost-tag and userip-tag modules. See discussion at: ircv3/ircv3-specifications#418
I've added a non-official InspIRCd implementation of this to the inspircd-contrib repo. I took the comments here into consideration and went with the names |
Oragono sends this information to privileged users in the WHOIS response, using the
I have no strong feelings about the present proposal; I'm really just mentioning 338 for completeness. |
Inspircd and Unreal appear to use |
Does this needs anything else? I think |
this appears to be quite similiar to solanum-ircd/solanum#13
|
Is there consensus on this across unreal, inspircd, solanum and oragono? |
We don't have an implementation but would be happy to implement a standardised version of this. |
I prefer the solanum design where you have to explicitly request a (new) CAP to get these. |
This issue came up in a new context (adding a new server tag to
|
This has been changed in master. |
Anyone want to turn this into a spec PR? |
Sorry for not checking in, didn't realize this sparked a lot more interest by now :D. I suppose I would be willing to make a PR for a spec like this, yeah. |
@syzop If you're interested in submitting a spec for this I would support it. |
Ok great, then I'll work on that. Expect something in July / August. |
@syzop Any updates on this? |
I was enthusiastic and had good intentions but... long story short: I'm sorry I let you down. I keep forgetting or postponing this. I think it's better if someone else works on this. So I don't keep delaying this for no good reason. |
In UnrealIRCd we implemented the following about 6 months ago. Credit for the idea does not go to me but to @westor7. I am just wondering if there is interest in the IRCv3 group of making this an official tag rather than a vendor tag like it is now.
We have the
unrealircd.org/userip
tag which adds user@ip information when the user has sufficient privileges to see such information (in our case, currently: user is IRCOp).Similarly, we have the
unrealircd.org/userhost
tag which adds user@realhost information.As we all know, the displayed host and IP may differ from the current active host (cloaking, vhost, etc).
Both tags are only sent if the recipient both 1) has sufficient privileges, and 2) has
message-tags
enabled.The end result is something like this:
@unrealircd.org/userhost=~x@localhost;unrealircd.org/[email protected];time=etc. :client!~x@Mask-4E7B8307 JOIN :#test
Why not alter the source for IRCOps
Perhaps on first sight one may wonder why we don't just alter the
:nick!user@host
source of messages sent to IRCOps. There are, in fact, a number of problems with that:When can this be useful?
This could be useful to trusted bots/scripts that may take action on the users with real host / real IPs. I suppose it could also be useful to trusted bots/scripts that log channel activity for legal or compliance reasons, but that may be a bit far fetched.
I totally admit the use case is not very broad, it is in fact limited. But I could see some use and that is why I implemented it. Also important for me, in my case it didn't clutter the source code and is self-contained, all the adding of this information is done automagically. It is also only sent to a limited number of people (IRCOps) so not wasting much overall server bandwidth.
Feedback
Let me know what you think. If there is no interest because it is too small of a use case or other reasons, then no problem, then it just stays a vendor tag.
The text was updated successfully, but these errors were encountered: