-
Notifications
You must be signed in to change notification settings - Fork 57
[V2.0] HDF Update and TopicHash Introduction #273
Conversation
Originally the plan was to include #259 in this PR as well, but what I have found is that there is no reasonable automated scenario that a user that would need to read the |
As a consequence of the above stated, it brings into question the need to store cursors by |
d0d268b
to
3b43db8
Compare
…ek20/streams into v2.0/signature-in-hdf
… v2.0/signature-in-hdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change and then good to go!
self.state.topics.iter() | ||
} | ||
|
||
pub(crate) fn topic_by_hash(&self, hash: &TopicHash) -> Option<Topic> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code, this didnt need to be cloned really. a reference is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use a reference we need to clone each time anyways to set the latest link for the branch each time a message is handled
Description of change
Addresses #260 and #256. Adds a MAC to the HDF for additional verification as well as adding the new
TopicHash
struct.CursorStore
now maps branches byTopicHash
instead ofTopic
, and HDF's now contain theTopic
asTopicHash
format instead of plaintext.Type of change
How the change has been tested