Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Support user-defined PskId #241

Open
arnauorriols opened this issue May 26, 2022 · 1 comment
Open

Support user-defined PskId #241

arnauorriols opened this issue May 26, 2022 · 1 comment

Comments

@arnauorriols
Copy link
Contributor

arnauorriols commented May 26, 2022

#237 (comment)

DoD

  • Users can define the PskId of the Psk.
  • Psk::to_pskid seems to express that PskId are always derived from Psk. To avoid confusion, this method should be renamed. Example: Psk::derive_pskid

Tips

  • Psk::to_pskid() is an indicative of the places that assume PskId are always derived from the Psk. Search places where Psk::to_pskid is used, and replace it for explicit PskId value
@kwek20
Copy link
Contributor

kwek20 commented Jun 2, 2022

As discussed when changing PSK location; Do we really need PskId?

Pros:

  • Users can make PskId aliases for easier usage and readability
  • No need to externally manage Psk after adding to stream, only PskId

Cons:

  • Users need to keep track of PskIds
  • Is the Psk realistically only for this stream?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants