Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes #171; brings more type checks for returned data #172

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ayushanand18
Copy link
Collaborator

@ayushanand18 ayushanand18 commented Dec 14, 2024

Overview

  • fixes OccResponse in occurrences #171; there were some inconsistencies with data returned by search queries on occurrences. For backwards compatibiity, execute still returns a DataFrame object, but sets data in OccResponse as dict({total: int, results: DataFrame/dict}). This fixes failing to_pandas method.
  • raise a NotImplementedError on calling to_pandas for non-supported data types
  • Resolves some FutureWarning while concatenating DataFrame during search. NA value columns while being merged with non-NA ones was throwing this warning. We do the merges while paginating large queries as API supports only 10k records at a time. So, we merge these chunks into one. Resolution was to skip merge during the first one (when the original results DataFrame is empty).
  • Add corresponding unittests.
  • Tiny typo on README that introduced an annoying tilda (`) on the link. Possibly came up during conversion from rst -> md.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OccResponse in occurrences
1 participant